Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/article teaser #34

Merged
merged 42 commits into from
Dec 6, 2023
Merged

Feature/article teaser #34

merged 42 commits into from
Dec 6, 2023

Conversation

kailasnadh790
Copy link
Collaborator

kailasnadh790 and others added 30 commits November 30, 2023 12:06
@kailasnadh790
image-cta
11ec35e 
URL for testing:

- https://feature-cta-image--famous-smoke-cigaradvisor--kailasnadh790.hlx.page/cigaradvisor/drafts/Kailas/image-cta
@kailasnadh790
Update imagecta.js
a997d51
@kailasnadh790
Update imagecta.js
949c494
@kailasnadh790
Update imagecta.js
e046696
@kailasnadh790
article-teaser
1dc0bd5
@kailasnadh790
optimized code
e7655bd
@kailasnadh790
Update imagecta.js
1913a44
@kailasnadh790
Update imagecta.js
59ad3b7
@kailasnadh790
Update article-teaser.js
eaa9e0b
@kailasnadh790
refactored code
ec30578
@kailasnadh790
initial commit
533f1ff
@kailasnadh790
css changes
4c1e41f
@kailasnadh790
css changes
8825d90
@kailasnadh790
alignment fixes
c52b45e
@kailasnadh790
moving foundation styling to style.css
63c8ac8
@kailasnadh790
date fix
e503e9d
@kailasnadh790
Update article-teaser.css
731781e
@kailasnadh790
Update article-teaser.js
8d36258
@kailasnadh790
Update article-teaser.js
f45a693
@bstopp
Save space for the image.
cd773a0
@bstopp
Fix lint.
5a36cea
@kailasnadh790
Update article-teaser.js
707244f
@kailasnadh790
Update imagecta.css
13093f3
@kailasnadh790
Merge branch 'feature/image-cta' of https://github.com/hlxsites/famou…
da38d22 
…s-smoke-cigaradvisor into feature/articleTeaser
@bstopp
Fix image hegiht on small screens.
de2f8d6
@kailasnadh790
Merge branch 'feature/image-cta' of https://github.com/hlxsites/famou…
25a4c62 
…s-smoke-cigaradvisor into feature/articleTeaser
@kailasnadh790
refactoring to remove ffetch
f6f8157
@kailasnadh790
Update article-teaser.js
9b7a91d
@kailasnadh790
link fixes
1b70427
@kailasnadh790
Update article-teaser.css
1171485
@kailasnadh790 kailasnadh790 requested a review from bstopp December 5, 2023 17:25
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 5, 2023 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/drafts/Kailas/article-teaser PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

bstopp
bstopp requested changes Dec 6, 2023
View reviewed changes
cigaradvisor/blocks/article-teaser/article-teaser.js Outdated Show resolved Hide resolved
cigaradvisor/blocks/article-teaser/article-teaser.js Outdated Show resolved Hide resolved
cigaradvisor/blocks/article-teaser/article-teaser.js Outdated Show resolved Hide resolved
cigaradvisor/styles/styles.css Outdated Show resolved Hide resolved
bstopp
bstopp requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to qualify the CSS to the block .article is really generic and may impact other blocks.

@kailasnadh790 kailasnadh790 merged commit e01bd7f into main Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kailasnadh790 @bstopp